Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update against new EVM interface & NFT interfaces #42

Merged
merged 15 commits into from
May 6, 2024
Merged

Update against new EVM interface & NFT interfaces #42

merged 15 commits into from
May 6, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Apr 19, 2024 •
edited
Loading

Closes: #25

⚠️ Should not be marked ready until changes to base EVM contract have been made in onflow/flow-go and should not be deployed until Previewnet HCU in the week of April 29th is complete

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling self-assigned this Apr 19, 2024
Base automatically changed from evm-updates to main April 24, 2024 16:31
@sisyphusSmiling sisyphusSmiling changed the title Update COA.deploy Update against new EVM interface May 1, 2024
@sisyphusSmiling sisyphusSmiling mentioned this pull request May 2, 2024
Closed
@sisyphusSmiling sisyphusSmiling changed the title Update against new EVM interface Update against new EVM interface & NFT interfaces May 3, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review May 4, 2024 00:17
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner May 4, 2024 00:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.00%. Comparing base (428634e) to head (a973ceb).
Report is 94 commits behind head on main.

Files Patch % Lines
...adence/contracts/bridge/FlowEVMBridgeNFTEscrow.cdc 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   82.88%   86.00%   +3.11%     
==========================================
  Files          18       18              
  Lines         818      886      +68     
==========================================
+ Hits          678      762      +84     
+ Misses        140      124      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit 8bbaa00 into main May 6, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the update-coa-deploy branch May 6, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

Assignees

@sisyphusSmiling sisyphusSmiling

Labels
EVM
Projects
FlowEVM Bridge
Status: Done
🌊 Flow 4D
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor on EVM.COA.deploy return value
3 participants
@sisyphusSmiling @codecov-commenter @joshuahannan